AmigaOS4 compilation failure (including buildbot)

[Raziel]

Hey there,

not sure where to post this other than here (no discord, no irc atm).
Maybe at the bugtracker?

Since the huge update to the glk/scott engine, i error out on compilation (and i can see that buildbot does too)

Code: Select all

engines/glk/scott/scott.cpp:1411:65: error: invalid conversion from 'Glk::glui32*' {aka 'long unsigned int*'} to 'uint*' {aka 'unsigned int*'}
[-fpermissive]

engines/glk/scott/scott.cpp:1580:51: error: invalid conversion from 'Glk::glui32*' {aka 'long unsigned int*'} to 'uint*' {aka 'unsigned int*'}
[-fpermissive]

engines/glk/scott/scott.cpp:1584:47: error: invalid conversion from 'Glk::glui32*' {aka 'long unsigned int*'} to 'uint*' {aka 'unsigned int*'}
[-fpermissive]

engines/glk/scott/scott.cpp:1602:52: error: invalid conversion from 'Glk::glui32*' {aka 'long unsigned int*'} to 'uint*' {aka 'unsigned int*'}
[-fpermissive]

engines/glk/scott/scott.cpp:1602:65: error: invalid conversion from 'Glk::glui32*' {aka 'long unsigned int*'} to 'uint*' {aka 'unsigned int*'}
[-fpermissive]

engines/glk/scott/scott.cpp:1613:93: error: invalid conversion from 'Glk::glui32*' {aka 'long unsigned int*'} to 'uint*' {aka 'unsigned int*'}
[-fpermissive]

engines/glk/scott/scott.cpp:1623:52: error: invalid conversion from 'Glk::glui32*' {aka 'long unsigned int*'} to 'uint*' {aka 'unsigned int*'}
[-fpermissive]

engines/glk/scott/scott.cpp:1623:65: error: invalid conversion from 'Glk::glui32*' {aka 'long unsigned int*'} to 'uint*' {aka 'unsigned int*'}
[-fpermissive]

engines/glk/scott/scott.cpp:1636:44: error: invalid conversion from 'Glk::glui32*' {aka 'long unsigned int*'} to 'uint*' {aka 'unsigned int*'}
[-fpermissive]

engines/glk/scott/scott.cpp:1636:57: error: invalid conversion from 'Glk::glui32*' {aka 'long unsigned int*'} to 'uint*' {aka 'unsigned int*'}
[-fpermissive]

engines/glk/scott/scott.cpp:2142:39: error: invalid conversion from 'Glk::glui32*' {aka 'long unsigned int*'} to 'uint*' {aka 'unsigned int*'}
[-fpermissive]

engines/glk/scott/scott.cpp:2142:47: error: invalid conversion from 'Glk::glui32*' {aka 'long unsigned int*'} to 'uint*' {aka 'unsigned int*'}
[-fpermissive]

AmigaOS4 - PPC - BE - SDL2
gcc (adtools build 11.2.0) 11.2.0

Thank you

[dreammaster]

Darn. I'll try to look into it if not tonight, then tomorrow night definitely.

[Raziel]

@dreammaster

/thumbs up
Thank you

[Raziel]

Darn. I'll try to look into it if not tonight, then tomorrow night definitely.

Confirmed fixed, thanks a lot

...

On a completely unrelated note...and since you work heavily with AGS lately...did you see this, this and this?

Suspecting endianess issues

Feel free to ignore

[dreammaster]

I'll start looking at bugs once I reach parity with upstream, just to be sure that none are things that were were already identified and fixed upstream.

[Raziel]

@dreammaster

/thumbs up
Understood, thank you very much

[Raziel]

Darn. I'll try to look into it if not tonight, then tomorrow night definitely.

Got another one today

Code: Select all

engines/ags/shared/gui/gui_main.cpp:94:5: error: no declaration matches 'int AGS3::AGS::Shared::GUIMain::FindControlAt(int, int, int,
bool) const'

[Raziel]

@dreammaster

Fixed, thanks a lot

[Raziel]

@dreammaster

And another one

Code: Select all

engines/ags/shared/gui/gui_main.cpp:149:16: error: invalid initialization of reference of type 'const AGS3::std::vector<int>&' from
expression of type 'const AGS3::std::vector<long int>'

[Raziel]

@dreammaster

Code: Select all

engines/ags/engine/ac/listbox.cpp:342:35: error: no matching function for call to 'Clamp(int&, int, AGS3::int32_t&)'

Should i keep posting those?
You'll probably catch them even without me.

[dreammaster]

Should i keep posting those?

It doesn't hurt. It takes such a long time for all the systems on Buildbot to finish compiling each batch that it's easy for me to forget to check the next day that there were issues for any systems. Your nudge in the forum is actually helpful in reminding me.