ScummVM needs OpenGL with xBRZ support

General chat related to ScummVM, adventure gaming, and so on.

Moderator: ScummVM Team

User avatar
Raziel
ScummVM Porter
Posts: 1013
Joined: Tue Oct 25, 2005 8:27 am
Location: A haunted Castle somewhere in the Bavarian Mountains
Contact:

Post by Raziel » Wed Mar 07, 2018 10:09 pm

Ah, damn, here i was hoping to get a relatively fast alpha test :-/

mahen
Posts: 1
Joined: Fri Mar 30, 2018 7:52 am

Post by mahen » Fri Mar 30, 2018 12:03 pm

Hi !

Meanwhile, you can use RetroArch with the ScummVM core, which enables you to apply any kind of pixel shader. You can even COMBINE xbrz + some CRT shaders, the result is incredible IMHO.

I'm not sure the ScummVM core is completely usable in Retroarch though, haven't tried for a long time !

cheers

User avatar
BeleG
Posts: 40
Joined: Mon Feb 16, 2009 12:31 pm

Post by BeleG » Fri Jul 27, 2018 12:50 am

I've recently contacted the creator of xBRZ in connection with his ScummVM build. Turns out he'd be happy for xBRZ to be integrated in the ScummVM master branch and has a suggestion to overcome the dependencies issue with MS PPL, which he has already successfully implemented in his other open source project FreeFileSync. If there is still dev interest in integrating xBRZ in ScummVM I would suggest checking that out.

As ever, many thanks for all the great work.

digitall
ScummVM Developer
Posts: 971
Joined: Thu Aug 02, 2012 1:40 pm

Post by digitall » Tue Jul 31, 2018 6:38 am

BeleG: Have taken a look at that forum thread and the FreeFileSync source code. For future reference in case your link is broken by SF.net forums change, the xBRZ author suggestion was to use the ThreadGroup class which is in FreeFileSync to replace the Microsoft PPL usage. However, looking in the FreeFileSync source code for 10.2, the xBRZ which is packaged with it seems to be using PPL as per the standard release. Apart from that, the ThreadGroup class is part of the zen library included and I took a look at the code dependencies for that. As far as I can see this is building on standard C++ threads, which might not be available on all ports. Our standard common code and OSystem only have the co-routines (originally added for Discworld engine).

In any case, none of this is insumountable, but I would think it would be easier to rewrite the xBRZ code to remove the need for multithreading or make it optional... but this is a not trivial amount of work.

As usual... patches and pull requests, especially when clean and modular will likely be accepted.

Lillesvamp
Posts: 2
Joined: Tue Dec 15, 2015 1:56 pm

Post by Lillesvamp » Wed Aug 01, 2018 10:59 am

xBRZ might simply be too slow to run single threaded.

Is there any chance a version using Intel's Thread Building Blocks would be accepted? That would at least work on Windows, Mac and Linux.

enderandrew
Posts: 8
Joined: Mon Feb 19, 2018 6:43 am

Post by enderandrew » Fri Aug 03, 2018 5:45 pm

Some people love the smoothing that xBRZ provides and some people hate it.

Personally, I'm really hoping to see this filter/scaler implemented in ScummVM someday.

LouEatingSalami
Posts: 7
Joined: Tue Feb 20, 2018 6:02 pm

Post by LouEatingSalami » Thu Aug 16, 2018 10:13 am

enderandrew wrote:Some people love the smoothing that xBRZ provides and some people hate it.

Personally, I'm really hoping to see this filter/scaler implemented in ScummVM someday.
You can already kind of do it using Reshade because somebody released a 5XBR shader for it and while it's not perfect it does look better than the standard built in scalers. Also it lets you add stuff like a CRT shader and noise filering to clean up the image. The "clarity" filter is also nice to add some shadows and highlights.

Post Reply