Pause / Break key equivalent for ScummVM?

General chat related to ScummVM, adventure gaming, and so on.

Moderator: ScummVM Team

Post Reply
andy_blah
Posts: 35
Joined: Thu Sep 07, 2006 7:44 am

Pause / Break key equivalent for ScummVM?

Post by andy_blah » Fri Feb 06, 2015 11:30 pm

In the PC versions of Scumm and AGI/SCI games, if you pressed on the Pause/Break key on the keyboard, the game would freeze but keep the music playing. Since trying out ScummVM, I haven't been able to find any similar functionality (by the press of a button) in ScummVM. I know it's not the same thing, and that the latter doesn't retain all the features of the original games but I thought I'd try anyway.
And yes, I know about pressing space in scumm games pauses the game, but that has the adverse effect of pausing the music too...

andy_blah
Posts: 35
Joined: Thu Sep 07, 2006 7:44 am

Post by andy_blah » Tue Feb 10, 2015 2:39 am

Nothing...?
Then maybe a patch that I could apply to ScummVM's source so I could get a similar functionality?

User avatar
Raziel
ScummVM Porter
Posts: 1061
Joined: Tue Oct 25, 2005 8:27 am
Location: a story that hasn't been written yet

Post by Raziel » Tue Feb 10, 2015 6:21 am

andy_blah wrote:Nothing...?
Then maybe a patch that I could apply to ScummVM's source so I could get a similar functionality?
You could open a FR at http://github.com/scummvm/scummvm and let the devs review your changes and additions,. great place to discuss source changes aswell.

User avatar
eriktorbjorn
ScummVM Developer
Posts: 3306
Joined: Mon Oct 31, 2005 7:39 am

Post by eriktorbjorn » Tue Feb 10, 2015 6:50 am

For the SCUMM engine, you could remove the calls to _sound->pauseSounds() from ScummEngine::pauseEngineIntern(), and I imagine at least some of the other game engines may be similar. The ones that have a pause feature, at least.

(I also imagine it could cause plenty of glitches in games where the action and music are supposed to stay in sync.)

andy_blah
Posts: 35
Joined: Thu Sep 07, 2006 7:44 am

Post by andy_blah » Tue Feb 10, 2015 12:43 pm

Raziel wrote: You could open a FR at http://github.com/scummvm/scummvm and let the devs review your changes and additions,. great place to discuss source changes aswell.
Thanks for the suggestion, but ScummVM doesn't have a issue tracker on github :)
eriktorbjorn wrote:For the SCUMM engine, you could remove the calls to _sound->pauseSounds() from ScummEngine::pauseEngineIntern(), and I imagine at least some of the other game engines may be similar. The ones that have a pause feature, at least.

(I also imagine it could cause plenty of glitches in games where the action and music are supposed to stay in sync.)
Where is that bit of code located?

User avatar
Raziel
ScummVM Porter
Posts: 1061
Joined: Tue Oct 25, 2005 8:27 am
Location: a story that hasn't been written yet

Post by Raziel » Tue Feb 10, 2015 1:18 pm

andy_blah wrote:
Raziel wrote: You could open a FR at http://github.com/scummvm/scummvm and let the devs review your changes and additions,. great place to discuss source changes aswell.
Thanks for the suggestion, but ScummVM doesn't have a issue tracker on github :)
I wasn't pointing you to one ;-)

Obviously it's a feature you want to have implemented not a bug, hence i pointed to the Feature Requests, or rather "Pull Requests".

You can describe the problems you're having in the PR and let the devs discuss, help or show you the places in the code you can try to change and work on.

User avatar
eriktorbjorn
ScummVM Developer
Posts: 3306
Joined: Mon Oct 31, 2005 7:39 am

Post by eriktorbjorn » Tue Feb 10, 2015 1:22 pm

andy_blah wrote:Thanks for the suggestion, but ScummVM doesn't have a issue tracker on github :)
For whatever reason, we're still using the one on SourceForge.
and_blah wrote:Where is that bit of code located?
It's in engines/scumm/scumm.cpp. I haven't looked at the other engines.

andy_blah
Posts: 35
Joined: Thu Sep 07, 2006 7:44 am

Post by andy_blah » Tue Feb 10, 2015 1:43 pm

Raziel wrote:Obviously it's a feature you want to have implemented not a bug, hence i pointed to the Feature Requests, or rather "Pull Requests".

You can describe the problems you're having in the PR and let the devs discuss, help or show you the places in the code you can try to change and work on.
Will do. Some github projects have issue trackers that double as wishlists. I never submitted a pull request, so I hope I'm not doing anything silly :P
eriktorbjorn wrote:For whatever reason, we're still using the one on SourceForge.
Will post there as well :)
Thanks!

andy_blah
Posts: 35
Joined: Thu Sep 07, 2006 7:44 am

Post by andy_blah » Tue Feb 10, 2015 5:24 pm

Okay, tried eriktorbjorn's suggestion and it does the job for now. The side effect is that now the music isn't stopped when I bring the menu (F5)
Also tried for the SCI engine, didn't seem to do much, and I can't test properly since there's no pause hotkey for the engine. The music however stopped when I brought up the save/load menu (F5)

Here's the patch if anyone is interested (doubt it).

Post Reply