WARNING: It seems Winuae is unreliable concerning colors displayed compared to e-uae (unix platform). IMO, there's some Windows platform problem, as e-uae in linux is working as I'm expecting: see comparison between quickgrab.005.png and screen1-euae.png below. Maybe 32bit palette used in window isn't a regular RGB palette like 12bit/24bit ones are, according to , or some kind RGB overlay is used by default in Windows and I can't get rid off. So this is my recommendation: don't use Winuae for testing purpose. Use e-uae (morgoth repositories) in a unix enviroment with a 24bit display mode.
@nolange: I realize you opened this bug report to see 2) solved. I wanted to talk with you personally before intervening, but kirben asked me to disccus here, so I did. It seems you are convinced that:
a) is impossible to map amiga native colors, as a 12bit palette is not a subset of a 24bit palette;
b) because of a, accuracy of colors in screenshots taken in a real amiga depend on how a 12bit color is converted in a 24bit color;
c) because of a, accuracy of colors in screenshots taken in a Winuae depend on how Winuae converts a 12bit color in a 24bit color;
d) because of a and b, it's ok to use Winuae as a reference because you trust more Winuae 12bit->24bit conversion;
e) scummvm uses the same 24bit colors that winuae actually (recent versions) displays.
My opinion is that a,d and e are not true:
a) 4096 colors is the OCS theoric palette (even if you could use really the full palette only on HAM mode). According :
(OCS Palette) = 4096 = 2^12 = 2^4 * 2^4 * 2^4 --> 4-4-4 representation
(Truecolor) = 2^24 = 2^8 * 2^8 * 2^8 --> 8-8-8 representation
2^8 / 2^4 = 2^4
Do you want to perform a conversion of the color x = (r,g,b) in a 12bit palette, 4-4-4 representation, to a color y in a 24bit palette, 8-8-8 representation? y = (c * 2^4, g * 2^4, b * 2^4)
The conversion is so easy that it doensn't need any rounding/truncating. Or the conversion is wrong?
d) As of 26 Sep 2005, (Win)UAE was using a bugged 12bit -> 24bit conversion, as I discovered ;
e) As far as I know, palette that are used NOW in scummvm were grabbed before 26 Sep 2005, so your affirmatation "all fixed palettes in ScummVM use the "WinUAE colors" may have been true before 26 Sep 2005, but it is no more actual.
Now, let pass to something more objective. The following is one of the screenshots I took in 2003:
It's in ILBM format, so probably it stored a 12bit rappresentations of colors (!). This was later converted in png:
Here is a screenshot taken today in e-uae (any recent build ):
With your favourite tool/app compare numerically the colors. Here are the results I got:
Code: Select all
Real Amiga e-uae (quickgrab.005.png) [screen1-euae.png] Red (Guybrush's skin) (255,85,85) (255,85,85) Yellow (the pixel on Gubrush's shoes) (255,255,85) (255,255,85) Violet (Governor's hat) (170,0,170) (170,0,170) Brown (Guybrush's hairs) (170,85,0) (170,85,0) ...
> Maybe amiga native screenshots are not paragonable with the grabs taken with winuae? ...
This was with or without AGA? Non-AGA modes should have exact the same colors, even at 16-bit.
Now, assuming e-uae and scummvm colors are comparable (and I think they should be, as e-uae IMO doesn't need to do any truncating/rounding), here is a scummvm screenshot:
NOTE: to compare e-uae colors with scummvm, I ran scummvm 0.13.1 in linux, to be 100% sure screenshots are really comparable.
and here is a numeric comparison between e-uae and scummvm colors:
Code: Select all
e-uae scummvm 0.13.1 [screen1-euae.png] [screen1-scummvm.png] Red (Guybrush's skin) (255,85,85) (248,84,80) Yellow (the pixel on Gubrush's shoes) (255,255,85) (248,252,80) Violet (Governor's hat) (170,0,170) (168,0,168) Brown (Guybrush's hairs) (170,85,0) (168,84,0) ...
To conclude: nolange, is good you want to fix the flower color (I confirm the bug) and be sure Guybrush's face color is ok, but I think I gave you enough hints that palettes used NOW in scummvm need first to be wholly rechecked.
As I told before, these are my recommendations: use e-uae in a 24bit display mode and gimp to grab screenshot. DON'T use Winuae.
 http://en.wikipedia.org/wiki/List_of_mo ... B_palettes
 http://www.freelists.org/post/uae/Palet ... and-WinUAE