Save/load slot bug in version 2.3.0

Ask for help with ScummVM problems

Moderator: ScummVM Team

Post Reply
Drumaster
Posts: 8
Joined: Wed Jun 29, 2016 8:48 am

Save/load slot bug in version 2.3.0

Post by Drumaster »

Hi guys,

I have a bug in the save/load menu in last ScummVM 2.3.0. I compiled the libretro core for the FunKey S from my repo:
https://github.com/DrUm78/scummvm

It runs very well on that awesome tiny device but a regression has been happening since version 2.1.1 (https://github.com/libretro/scummvm). I compiled both to compare and the bug occurs only on 2.3.0.

Bug description:
After selecting slot 0 with an existing save in Load/Save menu (either by clicking on it or by pressing Y key), the first four slots cannot be selected anymore. It does not occur with 640x480 resolution but with 320x240 or 240x240 though.
Video of the bug here.
As you can see, the slots 0, 1, 2 and 3 are selectable then are not anymore as soon as I click on the slot 0. Quitting the application is the only way to get rid of this bug.

From the file diff between 2.1.1 and last 2.3.0 (saveload.*, saveload-dialog.* files) I tried several things to restore the previous behavior but in vain, anyone has an idea (my coding skill is close to 0)? Am I looking into the right files? I ask here because the bug tracker seems already quite flooded.
Last edited by Drumaster on Sun Jun 20, 2021 5:12 pm, edited 1 time in total.
User avatar
sev
ScummVM Lead
Posts: 2272
Joined: Wed Sep 21, 2005 1:06 pm
Contact:

Re: Save/load slot bug in version 2.3.0

Post by sev »

Are you able to reproduce it with the normal ScummVM binaries? We cannot provide support for the libretro core simply because it has tons of additional code which we are not aware of and that includes input controls.

If you cannot reproduce it on stock ScummVM, then your best bet would be the libretro support.


Eugene
User avatar
Praetorian
ScummVM Developer
Posts: 782
Joined: Tue May 08, 2007 8:54 am
Location: Greece
Contact:

Re: Save/load slot bug in version 2.3.0

Post by Praetorian »

Oddly enough, this might be the exact same issue I encountered yesterday.

I've issued a fix in this PR, although it might need some extra work; namely expand the scope of the fix, or limit it to the saveload-dialog only.
https://github.com/scummvm/scummvm/pull/3080

quick summary of the issue: it's an awry invisible "thumbnail" area that prevents clicks from being registered by the list.
Drumaster
Posts: 8
Joined: Wed Jun 29, 2016 8:48 am

Re: Save/load slot bug in version 2.3.0

Post by Drumaster »

Praetorian wrote: Sun Jun 20, 2021 3:51 pm Oddly enough, this might be the exact same issue I encountered yesterday.

I've issued a fix in this PR, although it might need some extra work; namely expand the scope of the fix, or limit it to the saveload-dialog only.
https://github.com/scummvm/scummvm/pull/3080

quick summary of the issue: it's an awry invisible "thumbnail" area that prevents clicks from being registered by the list.
You're truly awesome, such a quick response and that fixes the issue, thanks a million. :)
Post Reply