Looking for help: Uniformizing the ScummVM webpages

General chat related to ScummVM, adventure gaming, and so on.

Moderator: ScummVM Team

Post Reply
User avatar
md5
ScummVM Developer
Posts: 2250
Joined: Thu Nov 03, 2005 9:31 pm
Location: Athens, Greece

Post by md5 »

3 more things:
- you got an IE rule in your regular CSS (the * html rule), which sets the content's height. Why is that needed?
- I put the text related rules above, cause the formatting of the link text in the tabs broke for some reaaon on hover - probably an odd cascade problem, but it was easier to just fix it with an !important rule
- I can't remember how to fix the issue where the cursor doesn't change into a hand in IE when hovered (I think it is somehow related to hasLayout), but again a simple rule to change the cursor sufficed...
billwashere
Posts: 63
Joined: Sat Feb 14, 2009 8:43 am
Location: Australia

Post by billwashere »

md5 wrote:As a side note, you're missing tab_b.png (defined in DIV.tabs)
Because these were based off doxygen's tabs they included it but never made it, so i haven't deleted it.
md5 wrote:the * html rule

this sets the height of the container to be same height as the menus. Also height has a different meaning in ie and firefox. from memory firefox's min-height is ie's height.
md5 wrote:cursor doesn't change into a hand in IE

I noticed that and i have been searching for a solution
billwashere
Posts: 63
Joined: Sat Feb 14, 2009 8:43 am
Location: Australia

Post by billwashere »

http://scummvm.comlu.com/ScummModern-0.07.zip

This should work! Well Kinda,

* The tabs are slightly higher on firefox (windows)

* The watch tab on firefox (windows) didn't want to change but if you refreshed it it changed

* The watch tab on ie6 once click the height changed.

* The Retrieved from "URL" is still there but hidden, don't know why it's printing.

* The printable version is not the best.

* Special:Preferences css should be changed to fit more naturally instead of being stolen from orginal skin

* Search in menu is slightly to the right

* A word cannot be longer than table (just above id container) otherwise it streches, a bug in the orginal design and a flaw in css
fingolfin
Retired
Posts: 1452
Joined: Wed Sep 21, 2005 4:12 pm

Post by fingolfin »

Thanks for your continued efforts, Bill! I hope somebody (filippos, thierry?) can look into reviewing and integrating your new theme into the Wiki. (Sadly, I currently can't do that, as my primary work machine died this morning :/).
User avatar
criezy
ScummVM Developer
Posts: 949
Joined: Sat Sep 23, 2006 10:41 am
Location: West Sussex, UK

Post by criezy »

fingolfin wrote:I hope somebody (filippos, thierry?) can look into reviewing and integrating your new theme into the Wiki.
I will have a look this week-end.
User avatar
md5
ScummVM Developer
Posts: 2250
Joined: Thu Nov 03, 2005 9:31 pm
Location: Athens, Greece

Post by md5 »

fingolfin wrote:Thanks for your continued efforts, Bill! I hope somebody (filippos, thierry?) can look into reviewing and integrating your new theme into the Wiki. (Sadly, I currently can't do that, as my primary work machine died this morning :/).
I'll have a look as well, in case I manage to fix the aforementioned issues.
User avatar
criezy
ScummVM Developer
Posts: 949
Joined: Sat Sep 23, 2006 10:41 am
Location: West Sussex, UK

Post by criezy »

Our wiki is now using this new version. I have to say it looks pretty good. Thanks again for all you great work on that skin.

Apart from the problems you mention (and the ones for firefox Windows are also present in firefox Mac by the way) I saw a couple of small issues with Opera:
1) The watch tab, after changing its label (i.e. if you click on it) appear to be cut on the left for both the "Unwatch" and "Watch (if you click a second time) labels. Refreshing solves the issue.
Image

2) The search bar is too much on the right (as with all the other browsers as you mentioned) but unlike the other browsers it goes up to the border of the box.
Image

One last thing: would it be possible to also hide the 'From ScummVM :: Wiki' and 'Jump to' lines at the top of each page?
billwashere
Posts: 63
Joined: Sat Feb 14, 2009 8:43 am
Location: Australia

Post by billwashere »

EDIT: Link http://scummvm.comlu.com/ScummModern-0.08.zip
criezy wrote:1) The watch tab
This should be fixed. I had to modify the ajaxwatch.js and wikibits.js so they now point to scummmodern folder.

Could someone please test safari? As there is some safari code found in changetext() in wikibits.js
criezy wrote:The search bar
This is now centered in everything except for webkit. So it should work
criezy wrote:One last thing
Deleted

Also I have add support for tables like the ones in http://scummvm.org/compatibility/.

Example
Replace the "Complete Engines in the Latest Stable Version" table in http://wiki.scummvm.org/index.php?title=Engines with

Code: Select all

{| cellspacing="2" cellpadding="5" width=100% class="chart color4"
|+ Complete Engines in the Latest Stable Version
|- class="color4" 
! width=100|Engine !! Games
|- class="color2"
| align=center valign=top|[[AGI]] ||
{| class="color2"
|- valign=top
|
* Early [[Sierra]] adventure games
** [[AGI Demo]]
** [[The Black Cauldron]]
** [[Christmas Card 1986]]
** [[Gold Rush]]
** [[King's Quest]]
** [[King's Quest II]]
** [[King's Quest III]]
** [[King's Quest IV]]
** [[Leisure Suit Larry]]
** [[Manhunter]]
** [[Manhunter 2]]
** [[Mixed-Up Mother Goose]]
** [[Police Quest]]
** [[Space Quest]]
** [[Space Quest II]]
** [[Seasons Greetings From Tandy]]
||
* Pre-AGI games
** [[Mickey's Space Adventure]]
** [[Troll's Tale]]
** [[Winnie the Pooh in the Hundred Acre Wood]]

* [[AGI/Fan Games|AGI Fan Games]]
|}
|- class="color0"
| align=center valign=top|[[AGOS]] ||
* [[Elvira: Mistress of the Dark]]
* [[Elvira 2: The Jaws of Cerberus]]
* [[The Feeble Files]]
* [[Simon the Sorcerer series]]
** [[Simon the Sorcerer]]
** [[Simon the Sorcerer II: The Lion, the Wizard and the Wardrobe]]
** [[Simon the Sorcerer Puzzle Pack]]
* [[Waxworks]]
|- class="color2"
| align=center valign=top|[[Cine]] ||
* [[Future Wars]]
|- class="color0"
| align=center valign=top|[[CruisE]] || 
* [[Cruise for a Corpse]] 
|- class="color2"
| align=center valign=top|[[Draci]] || 
* [[Dragon History]]
|- class="color0"
| align=center valign=top|[[Drascula]] || 
* [[Drascula: The Vampire Strikes Back]]
|- class="color2"
| align=center valign=top|[[Gob]] || 
{| class="color2"
|- valign=top
|
* [[Gobliiins]]
* [[Gobliins 2]]
* [[Goblins 3]]
* [[Ween: The Prophecy]]
||
* [[Bargon Attack]]
* [[Lost in Time]]
* [[The Bizarre Adventures of Woodruff and the Schnibble]]
* [[Fascination]]
|}
|- class="color0"
| align=center valign=top|[[Groovie]] ||
* [[The 7th Guest]]
|- class="color2"
| align=center valign=top|[[Kyra]] ||
* [[The Legend of Kyrandia]]
* [[The Legend of Kyrandia: Book Two: Hand of Fate]]
* [[The Legend of Kyrandia: Book Three: Malcolm's Revenge]]
|- class="color0"
| align=center valign=top|[[Lure]] ||
* [[Lure of the Temptress]]
|- class="color2"
| align=center valign=top|[[MADE]] ||
* [[Return to Zork]]
* [[Leather Goddesses of Phobos 2]]
* [[The Manhole]]
* [[Rodney's Funscreen]]
|- class="color0"
| align=center valign=top|[[Parallaction]] ||
* [[Nippon Safes Inc.]]
|- class="color2"
| align=center valign=top|[[Queen]] || 
* [[Flight of the Amazon Queen]]
|- class="color0"
| align=center valign=top|[[SAGA]] ||
* [[Inherit The Earth]]
* [[I Have No Mouth, and I Must Scream]]
|- class="color2"
| align=center valign=top|[[SCI]] ||
(SCI0-SCI1.1): Newer [[Sierra]] adventure games (based on FreeSCI):
{| class="color2"
|- valign=top
|
* [[Castle of Dr. Brain]]
* [[Codename: ICEMAN]]
* [[Conquests of Camelot]]
* [[Conquests of the Longbow]]
* [[EcoQuest|EcoQuest: The Search for Cetus]] 
* [[EcoQuest II|EcoQuest 2: Lost Secret of the Rainforest]]
* [[Freddy Pharkas|Freddy Pharkas: Frontier Pharmacist]]
* [[Hoyle's Official Book of Games: Volume 1]]
* [[Hoyle's Official Book of Games: Volume 2]]
* [[Hoyle's Official Book of Games: Volume 3]]
* [[Hoyle Classic Card Games]]
* [[Jones in the Fast Lane]]
* [[King's Quest|King's Quest I]]
* [[King's Quest IV]]
* [[King's Quest V]]
* [[King's Quest VI]]
* [[Laura Bow: The Colonel's Bequest]]
* [[The Dagger of Amon Ra|Laura Bow 2: The Dagger of Amon Ra]]
||
* [[Leisure Suit Larry|Leisure Suit Larry 1]]
* [[Leisure Suit Larry 2]]
* [[Leisure Suit Larry 3]]
* [[Leisure Suit Larry 5]]
* [[Leisure Suit Larry 6]]
* [[Mixed-Up Fairy Tales]]
* [[Mixed-Up Mother Goose]]
* [[Pepper's Adventures in Time]]
* [[Police Quest]]
* [[Police Quest II]]
* [[Police Quest III]]
* [[Quest for Glory]]
* [[Quest for Glory II]]
* [[Quest for Glory III]]
* [[Slater & Charlie Go Camping]]
* [[Space Quest]]
* [[Space Quest III]]
* [[Space Quest IV]]
* [[Space Quest V]]
* [[The Island of Dr. Brain]]
|}
|- class="color0"
| align=center valign=top|[[SCUMM]] ||
Classic 2D [[LucasArts]] games:
{| class="color0"
|- valign=top
|
* [[Maniac Mansion]]
* [[Zak McKracken and the Alien Mindbenders]]
* [[Indiana Jones and the Last Crusade]]
* [[Loom]]
* [[Passport to Adventure]]
* [[The Secret of Monkey Island]]
* [[Monkey Island 2: LeChuck's Revenge]]
||
* [[Indiana Jones and the Fate of Atlantis]]
* [[Day of the Tentacle]]
* [[Sam & Max Hit the Road]]
* [[Full Throttle]]
* [[The Dig]]
* [[The Curse of Monkey Island]]
|}
[[Humongous Entertainment]] games:
{| class="color0"
|- valign=top
|
* [[Backyard Football]]
* [[Backyard Football 2002]]
* [[Big Thinkers First Grade]]
* [[Big Thinkers Kindergarten]]
* [[Blue's ABC Time Activities]]
* [[Blue's 123 Time Activities]]
* [[Blue's Reading Time Activities]]
* [[Blue's Art Time Activities]]
* [[Fatty Bear's Birthday Surprise]]
* [[Fatty Bear's Fun Pack]]
* [[Freddi Fish 1: The Case of the Missing Kelp Seeds]]
* [[Freddi Fish 2: The Case of the Haunted Schoolhouse]]
* [[Freddi Fish 3: The Case of the Stolen Conch Shell]]
* [[Freddi Fish 4: The Case of the Hogfish Rustlers of Briny Gulch]]
* [[Freddi Fish 5: The Case of the Creature of Coral Cave]]
* [[Freddi Fish and Luther's Maze Madness]]
* [[Freddi Fish and Luther's Water Worries]]
* [[Let's Explore the Airport with Buzzy]]
* [[Let's Explore the Farm with Buzzy]]
* [[Let's Explore the Jungle with Buzzy]]
||
* [[Pajama Sam 1: No Need to Hide When It's Dark Outside]]
* [[Pajama Sam 2: Thunder and Lightning Aren't so Frightening]]
* [[Pajama Sam 3: You Are What You Eat From Your Head to Your Feet]]
* [[Pajama Sam: Games to Play On Any Day]]
* [[Pajama Sam's Lost & Found]]
* [[Pajama Sam's Sock Works]]
* [[Putt-Putt Joins the Parade]]
* [[Putt-Putt Goes to the Moon]]
* [[Putt-Putt Saves the Zoo]]
* [[Putt-Putt Travels Through Time]]
* [[Putt-Putt Enters the Race]]
* [[Putt-Putt Joins the Circus]]
* [[Putt-Putt's Fun Pack]]
* [[Putt-Putt & Fatty Bear's Activity Pack]]
* [[Putt-Putt and Pep's Balloon-O-Rama]]
* [[Putt-Putt and Pep's Dog on a Stick]]
* [[SPY Fox 1: Dry Cereal]]
* [[SPY Fox 2: Some Assembly Required]]
* [[SPY Fox 3: Operation Ozone]]
* [[SPY Fox in Cheese Chase]]
* [[SPY Fox in Hold the Mustard]]
|}
|- class="color2"
| align=center valign=top|[[Sky]] || 
* [[Beneath a Steel Sky]]
|- class="color0"
| align=center valign=top|[[Sword1]] ||
* [[Broken Sword 1]]
|- class="color2"
| align=center valign=top|[[Sword2]] ||
* [[Broken Sword 2]]
|- class="color0"
| align=center valign=top|[[Teen]] ||
* [[TeenAgent]]
|- class="color2"
| align=center valign=top|[[Tinsel]] ||
* [[Discworld series|Discworld Series]]:
** [[Discworld 1]]
** [[Discworld II: Missing Presumed...!?]]
|- class="color0"
| align=center valign=top|[[Touche]] ||
* [[Touché: The Adventures of the Fifth Musketeer]]
|- class="color2"
| align=center valign=top|[[Tucker]] ||
* [[Bud Tucker in Double Trouble]]
|- class="color0"
|}
billwashere
Posts: 63
Joined: Sat Feb 14, 2009 8:43 am
Location: Australia

Post by billwashere »

Just realised that extension jsMath won't unless you uncomment the line 106 in ScummModern.php
fingolfin
Retired
Posts: 1452
Joined: Wed Sep 21, 2005 4:12 pm

Post by fingolfin »

Great work!

Regarding jsmath, we should look into replacing that by MathJax.
billwashere
Posts: 63
Joined: Sat Feb 14, 2009 8:43 am
Location: Australia

Post by billwashere »

http://scummvm.comlu.com/ScummModern-0.09.zip

* Added Printable Version

* Updated ajaxwatch.js to your current WikiMedia's version

* Fixed search in navbar due to float drop in ie6

* Found out that The Retrieved from "URL" is found in original, so not a problem
User avatar
criezy
ScummVM Developer
Posts: 949
Joined: Sat Sep 23, 2006 10:41 am
Location: West Sussex, UK

Post by criezy »

I installed the latest version (0.09) on the wiki.

That looks pretty good to me. I think we can soon switch to this skin as the default for our wiki.
fingolfin
Retired
Posts: 1452
Joined: Wed Sep 21, 2005 4:12 pm

Post by fingolfin »

Awesome work!

I have some more feedback, though: First off, the discussion tab does not look quite right for me in Firefox 3.6.13 on Mac OS X 10.6, it is shifted upwards by one pixel:

Image

It looks correct in Chrome and Safari, though.

Moreover, I dislike that the bottom of the tabs is black (or at least very dark), while the upper end of the "page" they are attached to (i.e. the color gradient under the "User Manual" text in the image above) ends in a much lighter tone. This looks strange to me, and makes the tabs stand out , looking as if it was added only in hindsight (which it was, of course ;).

If the bottom was lighter, matching the color of the top end of gradient, maybe, then maybe things would look a lot better... No?
billwashere
Posts: 63
Joined: Sat Feb 14, 2009 8:43 am
Location: Australia

Post by billwashere »

Yeah firefox on mac and windows is quite displaying the tabs right but on linux it is. :?

I'll try and fix this asap.

By changing boarder to the same color (#ebb716) as the top the header you get
Image

NOTE: On the double line on Discussion
This can be achieved by changing the boarder's color in layout.css (ln 355) to #ebb716

This can be fixed if you remove the boarder
Image
This can be achieved by changing the boarder to none
If the bottom was lighter, matching...
I don't care, I simply do what I'm told


Also, what else needs uniformizing?
A new theme phpBB3 - started this
billwashere
Posts: 63
Joined: Sat Feb 14, 2009 8:43 am
Location: Australia

Post by billwashere »

Fixed tabs for all except firefox (linux)
Firefox in linux layout is different to any of the others and it seams to be impossible to target it it.

a updated css can be found here - http://pastebin.com/qA8xcCik
Post Reply