Scanlines 50%

General chat related to ScummVM, adventure gaming, and so on.

Moderator: ScummVM Team

Post Reply
User avatar
theelf
Posts: 24
Joined: Sun Feb 19, 2006 2:10 pm
Contact:

Scanlines 50%

Post by theelf » Sat Jul 20, 2013 9:59 pm

Hi!

There is a way to use scanlines in a 50 or custom %? any secret option? :wink:

I see a TV option, but is just too soft, looks like the scanlines are 10 or 20% only


Thanks!

digitall
ScummVM Developer
Posts: 1007
Joined: Thu Aug 02, 2012 1:40 pm

Post by digitall » Sun Jul 21, 2013 2:53 am

I'm sorry, but I'm not sure if I understand the question...

Is this in regard to the Options->Graphics Mode->TV2x scaler option in ScummVM?

If so, as far as I know, there are no configuration options for these.

Please note that we have an outstanding unmerged PR for improving/replacing these scalers with plugin versions, so options may be added in future after this is merged...
https://github.com/scummvm/scummvm/pull/271

User avatar
theelf
Posts: 24
Joined: Sun Feb 19, 2006 2:10 pm
Contact:

Post by theelf » Sun Jul 21, 2013 9:07 am

Hi, im sorry my question was not very clear, my english is not good

Yes, I was talking about TV2x option

Now, the scanlines in Scummvm are very "soft", maybe 10 to 20% black???

For example, very hard scanlines are 100% black, something like this

100% scanlines are best for emulators of arcade screens for example, that have big scanlines, but TV screen have very thin ones...


Image


...thats why I think 50% black scanlines, are much natural, and look very similar to old CRT than 100% black or the TV2x that scummvm uses now... (not exactly, I made in Photoshop... is something like 40%)


Image




Well, if not options now for TV2x, nothing to do! :D

I will wait like you say for future scalers!!

Anyways, for all developers, hope someone think is a good idea (I think yes, most emulators now have variable scanlines)

thanks

User avatar
LogicDeLuxe
Posts: 398
Joined: Thu Nov 10, 2005 9:54 pm

Post by LogicDeLuxe » Sun Jul 21, 2013 1:24 pm

I requested this about 10 years ago, and it was rejected with only one dismissive reply: http://sourceforge.net/tracker/index.ph ... tid=418823
:(

digitall
ScummVM Developer
Posts: 1007
Joined: Thu Aug 02, 2012 1:40 pm

Post by digitall » Sun Jul 21, 2013 8:20 pm

LogicDeLuxe: Apologies, but sounds like Fingolfin was having a bad day and most developers are already busy enough with bug fixes and development.

Feature Requests generally get a very low priority, especially those which are purely asthetic and we get a large number, most of which are fairly pointless.

This would be much more likely to be added if you provide a patch implementing the functionality that you would like to see i.e. as a patch on the patch tracker, or as a Github Pull Request.

The relevant code currently is in:
https://github.com/scummvm/scummvm/blob ... r.cpp#L320

The updated code for when the scalar plugins are merged can be found here:
https://github.com/lordhoto/scummvm/blo ... ler/tv.cpp

Provide a patch for these to add scanline adjustment between say 10% and 90% as a parameter... We can then look at adding the option code for GUI and configuration file to support this...

User avatar
theelf
Posts: 24
Joined: Sun Feb 19, 2006 2:10 pm
Contact:

Post by theelf » Sun Jul 21, 2013 9:26 pm

LogicDeLuxe wrote:I requested this about 10 years ago, and it was rejected with only one dismissive reply: http://sourceforge.net/tracker/index.ph ... tid=418823
:(
Ups... was not me :D

digitall wrote:LogicDeLuxe: Apologies, but sounds like Fingolfin was having a bad day and most developers are already busy enough with bug fixes and development.

Feature Requests generally get a very low priority, especially those which are purely asthetic and we get a large number, most of which are fairly pointless.

This would be much more likely to be added if you provide a patch implementing the functionality that you would like to see i.e. as a patch on the patch tracker, or as a Github Pull Request.

The relevant code currently is in:
https://github.com/scummvm/scummvm/blob ... r.cpp#L320

The updated code for when the scalar plugins are merged can be found here:
https://github.com/lordhoto/scummvm/blo ... ler/tv.cpp

Provide a patch for these to add scanline adjustment between say 10% and 90% as a parameter... We can then look at adding the option code for GUI and configuration file to support this...

I found your reply, very, VERY useful, thanks

I can see the code controlling the scanlines! and I think I know what to do... (hope)

I don't have Visual Studio, I never use in my life, but now I´m downloading VS Express, and I will try to do by myself

Thank you very much

Post Reply