Toonstruck - Android app crashes on certain scene switch

[Praetorian]

That is great news! Thank you very much for the quick response!

What is your experience with the app store? How long does it usually take after publishing a new version until it is available for end-users?

That could take a while. It is more dependant on when the ScummVM team decides to issue a new release (a bugfix one or a new major one) because at the end of that release cycle (when the actual release happens on all supported platforms) we upload the release apks to the Play Store (and hopefully Google has not added extra requirements that would disqualify our app update -- which is... a thing they tend to do).

So, for now, only the daily development builds will get the patch. Those are debug builds and *not* compatible with the release builds (so you cannot upgrade between them without losing your configuration (like added games and saved games especially if the later are not saved in external physical space, but rather in the application storage space).
If that's something you can risk/live with, you will be able to test with the development builds (about a day after I commit the fix).

[bmolsbeck]

Ah, understood.
But for me that is not a problem. I only have a few games registered, which I can easily register again. And my save games are located in a separate folder, outside of the application storage.

Can you let me know when a development build is available that includes your patch, and where I can find it?
Then I can remove the original app and install that APK.

[bmolsbeck]

Ah, I found this page:
https://buildbot.scummvm.org/#/dailybuilds

Will your pull request go into the master branch, or in the "ScummVM stable Future 2.7.x"?

[Praetorian]

It will go to the master branch which is the 2.8git development builds.

I am unsure if we update the "future x.x.x" builds daily unless we're in a release cycle (public beta etc).

I will however backport the patch to the 2.7.1 branch for a potential bugfix release (it's not certain that there will be one).

[bmolsbeck]

OK, thanks. Please let me know when it is merged.

[Praetorian]

Hello
Today's daily builds should contain the fix.
You'll probably need the arm64 one which corresponds to most Android smartphone device architectures nowadays.
Please test and report back so that we can verify (on more than one device) that it works and I will backport it to the potential bugfix branch as well.

[bmolsbeck]

I have some good news The issue has been solved in this build!
Many thanks!

[bmolsbeck]

Hi again!
Unfortunately I experience another crash a bit later on in the game.
I attached a save game to this post. All you have to do is give the robe in the square parcel to the scarecrow. Then a cut scene video is shown. After the video the game crashes.
I'm still on the same device, an Android 13 phone. And I am still using the daily build of May 11th.
Can you please have a look if you can reproduce the crash?

[Praetorian]

Hi again!
Unfortunately I experience another crash a bit later on in the game.
I attached a save game to this post. All you have to do is give the robe in the square parcel to the scarecrow. Then a cut scene video is shown. After the video the game crashes.
I'm still on the same device, an Android 13 phone. And I am still using the daily build of May 11th.
Can you please have a look if you can reproduce the crash?

Yep, I can reproduce. It's a similar case, but not fixed by the previous fix.
I've pushed a new commit to fix this a few minutes ago. Maybe tomorrow's daily build will get it.

[bmolsbeck]

That's fast! Thank you very much.
Please let me know when your fix is included in the daily build.

[Praetorian]

That's fast! Thank you very much.
Please let me know when your fix is included in the daily build.

It looks like (reading the buildbot logs) that the current daily build does indeed contain the fix (it actually contains two other more recent commits after mine too).

So you can test with it.

As a side note, I'm happy you're reporting back while playing through the game and we're catching and fixing these issues. I've also spotted a few other things that could use improvement but (other than a reported potential "freeze" case) they are not crashes/show stoppers.

And just to clarify, these issues are caught on Android 13 (because the app is forced to terminate when it's overreading an array) but they are engine-specific not Android specific.

[bmolsbeck]

I just tested the daily build of May 20th and the crash is solved. Again, many thanks!

I'm happy I can contribute this way to make the app better

[bmolsbeck]

Hi again!

I really thought I could play the game until the end with this build.
However, the almost very last screen crashes. Haha.

I again added a save game. Open it using Android 13 and tap on the panel on the right side of the computer. Then the game very shortly shows the panel where the crystals should be inserted, but then the game crashes.
Can you reproduce this?

[Praetorian]

Hi again!

I really thought I could play the game until the end with this build.
However, the almost very last screen crashes. Haha.

I again added a save game. Open it using Android 13 and tap on the panel on the right side of the computer. Then the game very shortly shows the panel where the crystals should be inserted, but then the game crashes.
Can you reproduce this?

I can. It looks like yet again another instance of the same issue, but manifested in a different drawing method, so it's not covered by the previous fixes.

I'll try to fix it today, and with luck the fix will be in tomorrow's development build.

[bmolsbeck]

Thank you for your quick response.
Please keep me updated!