ScummVM logo Forum Index - ScummVM website - Contact us - Buy Supported Games: GOG.com Rules - Search - Register - Login curved edge
Folder Forum Index > The Junkyard > Whatever happened to the in-progress AGS engine? Goto page Previous  1, 2, 3
Whatever happened to the in-progress AGS engine?
  Author    Thread Reply to topic
sev
ScummVM Lead


Joined: 21 Sep 2005
Posts: 1953
 

I also do not see a reason for any arguments.

E.g. I stepped in to clarify my description, not to paint things black or something.

It is a big pity to hear that pre-2.5 sources are lost. Maybe CJ would be able to provide his whole VSS dump? I have some experience with restoring old source control repositories, so I could help with converting it to git.

As I understand, at this moment, there is no ScummVM dev who expressed their interest in working on the engine. I would work on it by myself, but at this moment I have too much in my hands and too little time. Still, I think I could give a helping hand to whoever wants to work on it, or perhaps even put it as part of GSoC and mentor the task.

So, I propose to restart the thread, probably literally, from the very beginning and start assembling useful links like repos, working on backporting those fixes, and sketch the plan and current state of affairs.


Eugene

 Reply with quote  
Post Sat Dec 30, 2017 9:17 pm 
 View user's profile Send private message Visit poster's website
Raziel
ScummVM Porter


Joined: 25 Oct 2005
Posts: 961
Location: A haunted Castle somewhere in the Bavarian Mountains
 

Happy Smile

 Reply with quote  
Post Sat Dec 30, 2017 10:20 pm 
 View user's profile Send private message Visit poster's website
morganw



Joined: 08 Jan 2018
Posts: 2
 

Hi,

I'm interested in trying to complete the existing port. I imagine I'll be a bit slow to get going as I'm not familiar with ScummVM code or the finer points of AGS, and am a bit of a rookie with C++, but I'd like to give it a go.
If you could point me in the direction of the appropriate developer documentation I'll try to make a start. I'm guessing that everything which is available would be linked from here?

Thanks,
Morgan

 Reply with quote  
Post Tue Jan 09, 2018 7:37 pm 
 View user's profile Send private message
digitall
ScummVM Developer


Joined: 02 Aug 2012
Posts: 878
 

morganw: Yes... and see these:
http://wiki.scummvm.org/index.php/Engines#In-Progress.2FFrozen_Engines

http://wiki.scummvm.org/index.php/AGS

https://github.com/fuzzie/scummvm/tree/ags

Note that "This branch is 355 commits ahead, 21726 commits behind scummvm:master." so quite a bit of work is required to first bring the AGS engine code as-is up to date with changes in the ScummVM common and OSystem API i.e. to rebase this onto the latest master and correct build issues... reviewing the changes made in the meantime.

 Reply with quote  
Post Tue Jan 09, 2018 9:00 pm 
 View user's profile Send private message
Raziel
ScummVM Porter


Joined: 25 Oct 2005
Posts: 961
Location: A haunted Castle somewhere in the Bavarian Mountains
 

quote:
Originally posted by morganw
Hi,

I'm interested in trying to complete the existing port. I imagine I'll be a bit slow to get going as I'm not familiar with ScummVM code or the finer points of AGS, and am a bit of a rookie with C++, but I'd like to give it a go.
If you could point me in the direction of the appropriate developer documentation I'll try to make a start. I'm guessing that everything which is available would be linked from here?

Thanks,
Morgan


/me definitely watching this space

Good luck, Morgan
 Reply with quote  
Post Wed Jan 10, 2018 3:26 pm 
 View user's profile Send private message Visit poster's website
ikmspb



Joined: 24 Dec 2017
Posts: 9
 

quote:
Originally posted by sev

So, I propose to restart the thread, probably literally, from the very beginning and start assembling useful links like repos, working on backporting those fixes, and sketch the plan and current state of affairs.


If a new thread is due, where would be the best place to open it at your forums? Sorry, I am a bit unfamiliar with your website.

Since morganw already decided to go ahead and try something, we created a fork of fuzzie's work in our github organization account, with morganw having all working perms.

I have some worries regarding your conventions, my two questions are:
1. What should the engine branch be (re)based on - current master or tag corresponding to the last stable version?
2. Do you require perfectly clean rebase or allow continious merging with master branch? I ask because in the past fuzzie has merged master with "ags" branch at least once (it's the last commit in her repository.
 Reply with quote  
Post Sun Jan 14, 2018 11:49 am 
 View user's profile Send private message
digitall
ScummVM Developer


Joined: 02 Aug 2012
Posts: 878
 

ikmspb: To answer your questions, IMHO:
1. Branch based on the latest master and...
2. Don't do continual merging with master branch as it makes the history and merging the final engine / squashing / rebasing a nightmare during review.

I would suggest that you just rebase the existing engine code onto the latest master, deal with fixing commits to ensure that all commits in the engine code build (You can use a git script for git-bisect to check this) due to changes in the master common and other APIs.

I would refrain from doing merges, but leave the engine at the common branch point from master until you are further on and/or do a rebase onto the latest master code periodically repeating the original update.

 Reply with quote  
Post Sun Jan 14, 2018 5:37 pm 
 View user's profile Send private message
morganw



Joined: 08 Jan 2018
Posts: 2
 

Hello again,

Where would be the best place to ask ScummVM technical questions? I couldn't see an obvious place on the forum and wanted to ask about casting audio streams.

 Reply with quote  
Post Fri Feb 09, 2018 10:45 pm 
 View user's profile Send private message
tsoliman
ScummVM Developer


Joined: 19 Jan 2011
Posts: 395
Location: USA
 

probably IRC (#scummvm on freenode)
or
the mailing list scummvm-devel

 Reply with quote  
Post Fri Feb 09, 2018 11:16 pm 
 View user's profile Send private message Send e-mail
  Display posts from previous:      
Reply to topic

Forum Jump:
 
Goto page Previous  1, 2, 3


Forum Rules:
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum

 

Powered by phpBB © 2001, 2006 phpBB Group
Forum design by ScummVM team, icons by raina
curved edge   curved edge