ScummVM logo Forum Index - ScummVM website - Contact us - Buy Supported Games: GOG.com Rules - Search - Register - Login curved edge
Folder Forum Index > General Discussion > Simon The Sorcerer II - Blilingual CD (ITA/HEB)
Simon The Sorcerer II - Blilingual CD (ITA/HEB)
  Author    Thread Reply to topic
lucavittori



Joined: 16 Dec 2017
Posts: 6
Simon The Sorcerer II - Blilingual CD (ITA/HEB) 

I've got a bilingual original CD of the title in topic. Italian folder is not recognized anymore (it was on ScummVM for Windows ver. 0.71).
This is the unrecognized file:

https://www.4shared.com/file/4hO7hch2ei/GSPTR30.html

 Reply with quote  
Post Mon Jan 15, 2018 8:33 pm 
 View user's profile Send private message
digitall
ScummVM Developer


Joined: 02 Aug 2012
Posts: 884
 

lucavittori: You haven't indicated what Operating System you are running or what new version of ScummVM you have installed newer than v0.71 on Windows.

I guess that you have probably installed the latest v2.0.0 on Windows 10? Anyway, I suggest that you uninstall and try testing with older versions and let us know which version broke this after v0.71 (This is a "gross" version bisection and will help us work out why this has occurred and which code change did this):
http://www.scummvm.org/frs/scummvm/

 Reply with quote  
Post Tue Jan 16, 2018 12:13 am 
 View user's profile Send private message
lucavittori



Joined: 16 Dec 2017
Posts: 6
 

Actually ScummVM version I got is the latest.
I tried on Windows 10 X64, Lubuntu X86 and also Android.
None of the above recognize the file.
Old 0.71 does, but is uncompatible with Windows 10 and unavailable on other platforms from official repositories.

In the past I tried several versions on Windows after 0.71 (can't remember exactly which one) and none of those worked.

Actually I haven't a Windows machine with other OS than 10 X64. To do the tests you suggest I should setup a Windows VM (Maybe XP 32bit) and try every version after 0.71?

 Reply with quote  
Post Wed Jan 17, 2018 4:04 pm 
 View user's profile Send private message
lucavittori



Joined: 16 Dec 2017
Posts: 6
 

(meanwhile to let my daughter play with Simon2 I've set up a DOSBOX and played the CD in native environment)

 Reply with quote  
Post Wed Jan 17, 2018 4:05 pm 
 View user's profile Send private message
digitall
ScummVM Developer


Joined: 02 Aug 2012
Posts: 884
 

I suggest that you try running a VM with Windows XP as you suggest (This is useful for running older games anyway, which Win10 has broken support for) and trying at least v1.1.0 to see if the breakage is present then. 0.7.1 to 2.0.0 is a very wide area of code changes and we could do with narrowing this down to between two versions before we try to work out why this has occurred and fix it.

 Reply with quote  
Post Wed Jan 17, 2018 6:36 pm 
 View user's profile Send private message
lucavittori



Joined: 16 Dec 2017
Posts: 6
 

When I'll find time to setup a virtual XP I'll do for sure. Where can I download previous versions of ScummVM?

 Reply with quote  
Post Mon Jan 29, 2018 7:37 am 
 View user's profile Send private message
digitall
ScummVM Developer


Joined: 02 Aug 2012
Posts: 884
 

http://www.scummvm.org/frs/scummvm/

 Reply with quote  
Post Mon Jan 29, 2018 9:11 am 
 View user's profile Send private message
lucavittori



Joined: 16 Dec 2017
Posts: 6
 

Found!

Last working version with my copy of Simon2 is 0.8.0
First non working is 0.8.1

https://ibb.co/dDsdTb

https://ibb.co/gRfhob

 Reply with quote  
Post Mon Jan 29, 2018 10:08 am 
 View user's profile Send private message
digitall
ScummVM Developer


Joined: 02 Aug 2012
Posts: 884
 

Ah, I think the regression was in this change which was SVN r20177:
https://github.com/scummvm/scummvm/commit/eee5b6056e0cbab9b3e47261b38f683f03f99705

Since then the detection code has been updated several times and is now based on a predecessor variant of the AdvancedDetector:
http://wiki.scummvm.org/index.php/Advanced_Detector

The Hebrew version is listed, but maybe the dual version has slightly different files:
https://github.com/scummvm/scummvm/blob/master/engines/agos/detection_tables.h#L1702

 Reply with quote  
Post Mon Jan 29, 2018 10:45 am 
 View user's profile Send private message
digitall
ScummVM Developer


Joined: 02 Aug 2012
Posts: 884
 

Actually that detector is now exactly standard AdvancedDetector. This uses a match on a list of filenames, with MD5SUM checksum of the first <n> bytes where n is 5000 by default and a filesize in bytes (or -1 to ignore).

Look here for more information:
http://wiki.scummvm.org/index.php/Advanced_Detector#ADGameFileDescription_structure

I think the fallback detector could do with some work here, but for now, you should probably do a file listing and take MD5sums of your datafiles and see if you can work out what to change to fix the detection. If you can, I will apply the code change which will be added to the next daily build and future releases:
http://wiki.scummvm.org/index.php/Reporting_unknown_MD5_checksums

 Reply with quote  
Post Mon Jan 29, 2018 10:53 am 
 View user's profile Send private message
lucavittori



Joined: 16 Dec 2017
Posts: 6
 

So, you need the MD5 of ALL the files in the "ITALIAN" subdir of my SIMON2 copy?

Because i tried replacing only the GSPTR30, taking it from the "HEBREW" subdir and it works (but of course I've got hebrew subtitles instead italian).

 Reply with quote  
Post Mon Jan 29, 2018 11:34 am 
 View user's profile Send private message
digitall
ScummVM Developer


Joined: 02 Aug 2012
Posts: 884
 

No. Just the five files listed in both the Hebrew and Italian detection entries, with the MD5sum limited to 5000 bytes and the filesize in bytes as per:
https://github.com/scummvm/scummvm/blob/master/engines/agos/detection_tables.h#L1702

 Reply with quote  
Post Mon Jan 29, 2018 12:46 pm 
 View user's profile Send private message
  Display posts from previous:      
Reply to topic

Forum Jump:
 



Forum Rules:
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum

 

Powered by phpBB © 2001, 2006 phpBB Group
Forum design by ScummVM team, icons by raina
curved edge   curved edge