ScummVM logo Forum Index - ScummVM website - Contact us - Buy Supported Games: GOG.com Rules - Search - Register - Login curved edge
Folder Forum Index > Help and Support > ScummVM 2.0.0 - Hanging notes with real MIDI synth
ScummVM 2.0.0 - Hanging notes with real MIDI synth
  Author    Thread Reply to topic
Digitoxin



Joined: 07 Aug 2012
Posts: 9
ScummVM 2.0.0 - Hanging notes with real MIDI synth 

When using ScummVM 2.0.0 with a real MIDI tone generator (Yamaha MU-80), I get hanging notes when exiting ScummVM while playing Sierra SCI games. I haven't tried any other games yet.

Shouldn't ScummVM be sending a reset command to MIDI devices on exit to prevent this type of thing from happening?

 Reply with quote  
Post Wed Dec 20, 2017 12:18 am 
 View user's profile Send private message
Raziel
ScummVM Porter


Joined: 25 Oct 2005
Posts: 946
Location: A haunted Castle somewhere in the Bavarian Mountains
 

You were probably hit by this.

 Reply with quote  
Post Wed Dec 20, 2017 7:07 am 
 View user's profile Send private message Visit poster's website
Digitoxin



Joined: 07 Aug 2012
Posts: 9
 

Regardless of the engine being used, ScummVM should always send a reset command to the MIDI device on exit.

quote:
Originally posted by Raziel
You were probably hit by this.

 Reply with quote  
Post Wed Dec 20, 2017 7:34 am 
 View user's profile Send private message
Raziel
ScummVM Porter


Joined: 25 Oct 2005
Posts: 946
Location: A haunted Castle somewhere in the Bavarian Mountains
 

As written in the link i posted there was a big rewrite of SCI's MIDI part which unfortunately broke some things.

One of them (probably) were the issues you are expereincing.

If you try 1.9.0 you'll see that it does what you expect it to do and it will again, in a future version/revision.

 Reply with quote  
Post Wed Dec 20, 2017 12:19 pm 
 View user's profile Send private message Visit poster's website
snover
ScummVM Developer


Joined: 17 Dec 2017
Posts: 20
 

There is an open bug report about this. The MPU-401 driver does seem to be sending some reset-looking messages when it is destroyed, and not everyone experiences this problem, so I canít explain offhand why it might be happening to you. Providing more reproduction information in that ticket could be helpful.

quote:
Originally posted by Raziel
As written in the link i posted there was a big rewrite of SCI's MIDI part which unfortunately broke some things.


This is actually the complete opposite of what I wrote in that thread.
 Reply with quote  
Post Wed Dec 20, 2017 5:20 pm 
 View user's profile Send private message
Raziel
ScummVM Porter


Joined: 25 Oct 2005
Posts: 946
Location: A haunted Castle somewhere in the Bavarian Mountains
 

Yep, sorry...mixed up the fact that there is a big rewrite needed...too tired

 Reply with quote  
Post Wed Dec 20, 2017 5:29 pm 
 View user's profile Send private message Visit poster's website
Digitoxin



Joined: 07 Aug 2012
Posts: 9
 

I have several external MIDI devices so I'll do some extensive testing on this and post my results on the bug report.

quote:
Originally posted by snover
There is an open bug report about this. The MPU-401 driver does seem to be sending some reset-looking messages when it is destroyed, and not everyone experiences this problem, so I canít explain offhand why it might be happening to you. Providing more reproduction information in that ticket could be helpful.

quote:
Originally posted by Raziel
As written in the link i posted there was a big rewrite of SCI's MIDI part which unfortunately broke some things.


This is actually the complete opposite of what I wrote in that thread.

 Reply with quote  
Post Thu Dec 21, 2017 12:11 am 
 View user's profile Send private message
  Display posts from previous:      
Reply to topic

Forum Jump:
 



Forum Rules:
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum

 

Powered by phpBB © 2001, 2006 phpBB Group
Forum design by ScummVM team, icons by raina
curved edge   curved edge