ScummVM logo Forum Index - ScummVM website - Contact us - Buy Supported Games: GOG.com Rules - Search - Register - Login curved edge
Folder Forum Index > PSP Port > ScummVM PSP with 4x3 aspect radio
ScummVM PSP with 4x3 aspect radio
  Author    Thread Reply to topic
dam-soft



Joined: 16 Apr 2017
Posts: 11
ScummVM PSP with 4x3 aspect radio 

Hi,

As everyone probably knows, the PSP ScummVM port has incorrect 4x3 aspect radio. That is why I have recompiled my own version of ScummVM that removes this inconvenience.
Below are the screenshots of the original port of the PSP port (upper image) and my version (lower image).




If anyone wants a fixed version of the PSP port, please PM.

 Reply with quote  
Post Thu Sep 21, 2017 2:49 pm 
 View user's profile Send private message
DragonBoy



Joined: 02 May 2016
Posts: 5
 

Thank you very much for your effort! Playing Fate of Atlantis as I write this at its proper resolution! Smile Smile

 Reply with quote  
Post Wed Sep 27, 2017 6:00 pm 
 View user's profile Send private message
rsn8887



Joined: 23 Jan 2016
Posts: 13
Re: ScummVM PSP with 4x3 aspect radio 

quote:
Originally posted by dam-soft
Hi,

As everyone probably knows, the PSP ScummVM port has incorrect 4x3 aspect radio. That is why I have recompiled my own version of ScummVM that removes this inconvenience.
Below are the screenshots of the original port of the PSP port (upper image) and my version (lower image).




If anyone wants a fixed version of the PSP port, please PM.


Nice work! Why donít you put your work on github and also put the release up there? That way everyone can benefit from your work and someone might even merge the fix into the main Scumm.
 Reply with quote  
Post Fri Dec 01, 2017 12:32 pm 
 View user's profile Send private message
dam-soft



Joined: 16 Apr 2017
Posts: 11
 

I've already place my suggetion in ScummVM bugtracker (ScummVM Issue Tracker) but there is still no response from ScummVM Team.

 Reply with quote  
Post Sun Dec 17, 2017 3:18 pm 
 View user's profile Send private message
digitall
ScummVM Developer


Joined: 02 Aug 2012
Posts: 882
 

dam-soft: I assume you mean this ticket?
https://bugs.scummvm.org/ticket/10239

Can you please attach a code patch for your proposed changes to that ticket? That should get this applied fairly quickly if there are no arguments.

A Github Pull Request would be even better with a link added to the ticket, but a patch will be sufficient.

 Reply with quote  
Post Sun Dec 17, 2017 5:26 pm 
 View user's profile Send private message
dam-soft



Joined: 16 Apr 2017
Posts: 11
 

I've already updated my ticket with precise information about where and what should be changed in the source code.

 Reply with quote  
Post Wed Dec 27, 2017 9:02 am 
 View user's profile Send private message
digitall
ScummVM Developer


Joined: 02 Aug 2012
Posts: 882
 

Thanks. Will convert your information to a patch and Pull Request this so that the team and PSP porter can provide feedback.

 Reply with quote  
Post Wed Dec 27, 2017 10:23 am 
 View user's profile Send private message
digitall
ScummVM Developer


Joined: 02 Aug 2012
Posts: 882
 

Have opened a Pull Request for this as:
https://github.com/scummvm/scummvm/pull/1096

 Reply with quote  
Post Wed Dec 27, 2017 11:51 am 
 View user's profile Send private message
dam-soft



Joined: 16 Apr 2017
Posts: 11
 

Thanks for support.

 Reply with quote  
Post Wed Dec 27, 2017 1:19 pm 
 View user's profile Send private message
Driller



Joined: 07 Jul 2014
Posts: 1
 

Dam-soft. My replies to you won't get beyond my 'Outbox' anymore for some reason, so can't reply to you any longer. You have my email. Can you send me both compiles as I have both a PSP-1000 and PSP-2003. Thanks.

 Reply with quote  
Post Fri Dec 29, 2017 2:12 am 
 View user's profile Send private message
rsn8887



Joined: 23 Jan 2016
Posts: 13
 

A fix for this has now been merged into the official ScummVM code.

Thanks to all those involved!

Sadly, current development buildbot builds crash when loading any game due to some other, non-related issue. This will be not be fixed until a new Docker-based buildbot is implemented.

In the meantime, you can try a recent ScummVM daily build (unofficial, untested) with the new code for the 4:3 graphics mode here:
https://github.com/rsn8887/scummvm/releases/


 Reply with quote  
Post Tue Jan 02, 2018 11:23 pm 
 View user's profile Send private message
  Display posts from previous:      
Reply to topic

Forum Jump:
 



Forum Rules:
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum

 

Powered by phpBB © 2001, 2006 phpBB Group
Forum design by ScummVM team, icons by raina
curved edge   curved edge