ScummVM logo Forum Index - ScummVM website - Contact us - Buy Supported Games: GOG.com Rules - Search - Register - Login curved edge
Folder Forum Index > Help and Support > Macintosh music in SCI games
Macintosh music in SCI games
  Author    Thread Reply to topic
almeath



Joined: 14 Mar 2008
Posts: 34
Macintosh music in SCI games 

I read on the compatibility page that Macintosh music in SCI games may have glitches. Indeed, when I tested King's Quest V in ScummVM and SheepShaver, the former definitely has some quirks and sounds a bit "off".

I was wondering if anyone can elaborate on why this is the case, and could it potentially be adresssd sometime in the forseeable future?

It is arguable that the MT-32 soundtracks in the PC versions of Sierra games are superior, but in my opinion the Macintosh versions do have their particular distinctiveness and charm.

 Reply with quote  
Post Mon Mar 13, 2017 1:53 pm 
 View user's profile Send private message
waltervn
ScummVM Developer


Joined: 14 Apr 2008
Posts: 14
 

I wrote new sound code for SCI0 and SCI1 Mac games a few years ago, but it's not available in master yet. If you're feeling adventurous, you can try it out by compiling the 'sci_sound' branch at https://github.com/waltervn/scummvm/tree/sci_sound

 Reply with quote  
Post Mon Mar 13, 2017 10:08 pm 
 View user's profile Send private message
Collector



Joined: 30 Oct 2005
Posts: 528
 

I have noticed such glitches or stuttering in Mac DGDS games in Basilisk II, as well. Could this be an SDL issue since it is used by both projects.

 Reply with quote  
Post Mon Mar 13, 2017 10:36 pm 
 View user's profile Send private message Visit poster's website
almeath



Joined: 14 Mar 2008
Posts: 34
 

I have compiled the sci_sound branch in macOS and and it appears to resolve the audio glitches, at least in KQV, thanks. Smile

I will test it with others and see how I go.

 Reply with quote  
Post Sat Mar 18, 2017 5:57 am 
 View user's profile Send private message
almeath



Joined: 14 Mar 2008
Posts: 34
 

So the sci_sound branch worked great for the following 256 color games currently supported in ScummVM:

- King's Quest V
- Space Quest IV

However Leisure Suit Larry 5 seems to be bugged in this build, because ScummVM crashes every time I try to get past the in-game password feature, with the following error:

error: uninitialized read for temp 1 from method : : export 0 (room 155, script 175, localCall ffffffff)!

This error does not occur in ScummVM 1.9 but of course the sound is 'buggy' as mentioned above.

I'm happy though because I was never into the LL games. I look forward to future releases that might end up supporting the Mac versions of King's Quest VI and VII .. and hopefully also incorporating waltervn's excellent work on the SCI sound code.

*update* Looks like King's Quest VI works too. The ScummVM compatibility page may need some editing because it currently lists only the PC and Amiga versions as being supported.

 Reply with quote  
Post Tue Mar 21, 2017 5:47 am 
 View user's profile Send private message
OmerMor
Got a warning


Joined: 17 Nov 2005
Posts: 141
Location: Israel
 

This looks like a script bug in LSL5:

code:

(procedure (proc175_0 &tmp temp0 temp1)
   (localproc_000e)
   (DrawPic 110)
   (localproc_0234)
   (if (StrCmp @local10 {NONE})
      (= local0 0)
   else
      (StrCpy @local0 @local10)
   )
   (while
      (and
         (< local20 5)
         (or
            (not (= temp0 (localproc_0134)))
            (StrCmp @local10 @local0)
         )
      )
   )
   (cond
      ((== local20 5)
         (proc255_0 175 0 80 {Five Strikes and You're Out!})
         (= global4 1)
         (gGame quitGame: 1)
      )
      ((== temp0 2)
         (proc255_2 @local0 20 {Please enter your new password:})
         (localproc_01b7)
         (StrCpy @local10 @local0)
         (localproc_0274)
         (proc255_4 175 1 @local0 80 {Write this down!})
      )
   )
   (DisposeScript 993)
   (return temp1)
)




The temp variable temp1 is being returned w/o being initialized.
The PC version of this games uses a different logic which doesn't have this bug.
 Reply with quote  
Post Tue Mar 21, 2017 8:11 pm 
 View user's profile Send private message Visit poster's website
waltervn
ScummVM Developer


Joined: 14 Apr 2008
Posts: 14
 

quote:
Originally posted by almeath
So the sci_sound branch worked great for the following 256 color games currently supported in ScummVM:

- King's Quest V
- Space Quest IV
Great. Smile

quote:
Originally posted by almeath
error: uninitialized read for temp 1 from method : : export 0 (room 155, script 175, localCall ffffffff)!

This error does not occur in ScummVM 1.9 but of course the sound is 'buggy' as mentioned above.
You'll probably find that this error happens in master as well, because the sci_sound branch only contains sound-related changes.
 Reply with quote  
Post Mon Mar 27, 2017 8:18 am 
 View user's profile Send private message
  Display posts from previous:      
Reply to topic

Forum Jump:
 



Forum Rules:
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum

 

Powered by phpBB © 2001, 2006 phpBB Group
Forum design by ScummVM team, icons by raina
curved edge   curved edge